Reduce dependency on web audio #190

pendragon-andyh · 2020-07-28T21:23:44Z

Fixes for:
. #145 (Initialize Without Web Audio Context)
. #147 (10% cpu usage by pulseaudio when a UI is loaded)

Notes:
. Need to regenerate api.json file.
. Need to update the NPM version numbers in the API index.html (or use @next?)

I have added pull-request comments so that you can more easily understand what I'm thinking.

api/index.html

pendragon-andyh · 2020-07-28T21:28:07Z

api/index.html

-  if (Nexus.context.close) {
-    Nexus.context.close();
-  }


Looking at the new Nexus.context causes an AudioContext to be created (see the new version of main.js).

pendragon-andyh · 2020-07-28T21:33:37Z

lib/interfaces/meter.js

@@ -28,45 +29,21 @@ import { context } from '../main';

 export default class Meter extends Interface {
  constructor() {
-    let options = ['scale', 'value'];


scale and value don't seem to be used in Meter, Oscilloscope, and Spectrogram. Smells like copy-and-paste.

pendragon-andyh · 2020-07-28T21:35:38Z

lib/interfaces/meter.js

@@ -142,46 +119,59 @@ export default class Meter extends Interface {
  }

  /**
-  Equivalent to "patching in" an audio node to visualize. NOTE: You cannot connect audio nodes across two different audio contexts. NexusUI runs its audio analysis on its own audio context, Nexus.context. If the audio node you are visualizing is created on a different audio context, you will need to tell NexusUI to use that context instead: i.e. Nexus.context = YourAudioContextName. For example, in ToneJS projects, the line would be: Nexus.context = Tone.context . We recommend that you write that line of code only once at the beginning of your project.


The "NOTE" and the first line of the original example are no longer relevant.

pendragon-andyh · 2020-07-28T21:37:46Z

lib/interfaces/meter.js

-    if (channels) {
-      this.channels = channels;
-    } else if (node.channelCount) {
-      this.channels = node.channelCount;
-    } else {
-      this.channels = 2;
+
+    this.channels = channels || node.channelCount || 2;


pendragon-andyh · 2020-07-28T21:38:43Z

lib/interfaces/meter.js

  }

  click() {
-    this.active = !this.active;
+    this.active = !this.active && this.source;


Only toggle if the meter is connected to an AudioNode.

pendragon-andyh · 2020-07-28T21:42:20Z

lib/main.js

+function unlockAudioContext(audioContext) {
+  const events = ['touchstart', 'touchend', 'mousedown', 'keydown'];
+
+  function unlock() {
+    events.forEach((eventName) => document.body.removeEventListener(eventName, unlock));
+    if (audioContext.state === 'suspended') {
+      console.log('Audio context - unlocked ...');
+      audioContext.resume();
+    }
+  }
+
+  if (audioContext.state === 'suspended') {
+    console.log('Audio context - suspended until user interaction ...');
+    events.forEach(eventName => {
+      document.body.addEventListener(eventName, unlock, false);
+    });
+  }
+}


Not sure about this. Similar code seems to be used by multiple WebAudio projects (because AudioContext is supposed to initialize in a "suspended" state). Recent WebAudio issues indicate that this is implemented differently between the different browsers.

pendragon-andyh · 2020-07-28T21:43:42Z

lib/main.js


 /**
 NexusUI => created as Nexus
 */

 class NexusUI {

-    constructor(context) {


Not sure if reformatting was caused by editor or lint settings.

pendragon-andyh · 2020-07-28T21:48:10Z

lib/main.js

+      this._clock = new WAAClock(this.context);
+      this._clock.start();


Clock is only created (and started) when it is specifically requested. I didn't create a setter.

[Nexus UI Tutorial](https://nexus-js.github.io/ui/api/#intro), but for Vue.js with [async components](https://vuejs.org/v2/guide/components-dynamic-async.html#Async-Components) loading to enable the web audio context. The async stuff might not be needed when the [relevant PR is merged](nexus-js/ui#190).

tatecarson

Looks good to me, thanks for all the work.

* updated discord message * feat: support for vertical orientation (#115) * fix: Nexus.tune.createScale() does not produce expected scale (#138) * fix: numberOfSliders does not change number of sliders for Multislider (#161) * feat: support for vertical orientation (#115) * feat: add padding to sequencer (#150) #178 * feat: add padding to sequencer (#150) #178 * removed commented out line * chore(release): 2.1.0 * chore(release): 2.1.1 * chore(release): 2.1.2 * add build * fix issue #161 * modify regex to support input of negative numbers to number component * update dist after regex change * chore(release): 2.1.3 * 🐛 Fix Nexus.Interval import regression * Fix Nexus.Interval import regression #184 * chore(release): 2.1.4 * Implement multi-touch piano * chore(release): 2.1.5 * Remove document.write * Rebuild dist files * Fix broken CSS in examples * Bump websocket-extensions from 0.1.3 to 0.1.4 (#185) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump standard-version from 7.1.0 to 8.0.1 (#187) Bumps [standard-version](https://github.com/conventional-changelog/standard-version) from 7.1.0 to 8.0.1. - [Release notes](https://github.com/conventional-changelog/standard-version/releases) - [Changelog](https://github.com/conventional-changelog/standard-version/blob/master/CHANGELOG.md) - [Commits](conventional-changelog/standard-version@v7.1.0...v8.0.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Reduce dependency on web audio (#190) * Only create AudioContext when necessary * Tweak npm version * Rebuild dist files * update documention cdn to use latest build * fixed mistake * fixed main and build * "chore(release): 2.1.6" * Update index.html trying to get it to rebuild Co-authored-by: Vladan Sarac <[email protected]> Co-authored-by: jamesstaub <[email protected]> Co-authored-by: Theis Bazin <[email protected]> Co-authored-by: Andy Harman <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andy Harman <[email protected]>

pendragon-andyh added 3 commits July 28, 2020 18:50

Only create AudioContext when necessary

391ca13

Tweak npm version

89c4b13

Rebuild dist files

6489fb1

pendragon-andyh commented Jul 28, 2020

View reviewed changes

api/index.html Show resolved Hide resolved

pendragon-andyh commented Jul 28, 2020

View reviewed changes

pendragon-andyh marked this pull request as ready for review July 28, 2020 21:51

pendragon-andyh mentioned this pull request Aug 8, 2020

Oscilloscope not connecting to Tone.js audio context #89

Open

tatecarson self-assigned this Aug 27, 2020

tatecarson approved these changes Aug 29, 2020

View reviewed changes

tatecarson merged commit fc13997 into nexus-js:master Aug 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reduce dependency on web audio #190

Reduce dependency on web audio #190

pendragon-andyh commented Jul 28, 2020 •

edited

Loading

pendragon-andyh Jul 28, 2020

pendragon-andyh Jul 28, 2020

pendragon-andyh Jul 28, 2020 •

edited

Loading

pendragon-andyh Jul 28, 2020

pendragon-andyh Jul 28, 2020

pendragon-andyh Jul 28, 2020

pendragon-andyh Jul 28, 2020

pendragon-andyh Jul 28, 2020

tatecarson left a comment

		this._clock = new WAAClock(this.context);
		this._clock.start();

Reduce dependency on web audio #190

Reduce dependency on web audio #190

Conversation

pendragon-andyh commented Jul 28, 2020 • edited Loading

pendragon-andyh Jul 28, 2020

Choose a reason for hiding this comment

pendragon-andyh Jul 28, 2020

Choose a reason for hiding this comment

pendragon-andyh Jul 28, 2020 • edited Loading

Choose a reason for hiding this comment

pendragon-andyh Jul 28, 2020

Choose a reason for hiding this comment

pendragon-andyh Jul 28, 2020

Choose a reason for hiding this comment

pendragon-andyh Jul 28, 2020

Choose a reason for hiding this comment

pendragon-andyh Jul 28, 2020

Choose a reason for hiding this comment

pendragon-andyh Jul 28, 2020

Choose a reason for hiding this comment

tatecarson left a comment

Choose a reason for hiding this comment

pendragon-andyh commented Jul 28, 2020 •

edited

Loading

pendragon-andyh Jul 28, 2020 •

edited

Loading